Close tools picker when chat mode changes #283317
Open
+30
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #264548 by ensuring the tools picker automatically closes when the chat mode changes. The implementation adds cancellation token support to the tools picker and uses an observable-based pattern to detect mode changes.
Key Changes
- Added optional
CancellationTokenparameter toshowToolsPickerfunction to support external cancellation - Implemented mode change detection in
ConfigureToolsActionusingautorunto monitor the current chat mode - Properly manages resource disposal with try-finally blocks to prevent leaks
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/actions/chatToolPicker.ts |
Adds optional cancellation token parameter and listener to close picker when token is cancelled |
src/vs/workbench/contrib/chat/browser/actions/chatToolActions.ts |
Implements mode change detection using autorun observable pattern and passes cancellation token to picker |
src/vs/workbench/contrib/chat/browser/actions/chatToolPicker.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264548