Use different color for voice recording icon/animation #283309
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the color used for the voice recording icon/animation in the chat interface from ACTIVITY_BAR_BADGE_BACKGROUND (blue notification badge color) to ACTIVITY_BAR_FOREGROUND (white active item color) to provide better visual distinction and semantic correctness for the recording state indicator.
Key Changes
- Updated the color constant from
ACTIVITY_BAR_BADGE_BACKGROUNDtoACTIVITY_BAR_FOREGROUNDfor the active recording animation
Member
|
Thanks! @mrleemurray maybe you could also chime in for this color change: the idea is to show the active voice recording icon in a stronger "active" color, that is why I picked the badge color, which is blue in most default themes. But that does not work in all themes, as this issue shows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #265676
Tested with light, dark, and the theme from the bug - all look good.