add a command to toggle between todos and chat input #283134
Open
+134
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a command to toggle focus between the agent TODOs view and the chat input, addressing issue #281597. The implementation adds new methods across multiple layers of the chat widget architecture to support focusing and checking the state of the TODO list widget.
Key Changes
- Added a new F1 command "Agent TODOs: Focus on Todos View" that toggles focus between the TODOs view and chat input
- Implemented focus management methods across ChatTodoListWidget, ChatInputPart, and ChatWidget
- Added comprehensive tests for the new focus and visibility checking functionality
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/chat.ts | Added focusTodosView() and toggleTodosViewFocus() methods to IChatWidget interface |
| src/vs/workbench/contrib/chat/browser/chatWidget.ts | Implemented the new interface methods to delegate todo list focus operations to the input part |
| src/vs/workbench/contrib/chat/browser/chatInputPart.ts | Added helper methods to check and control todo list focus and visibility state |
| src/vs/workbench/contrib/chat/browser/chatContentParts/chatTodoListWidget.ts | Implemented core focus management: hasTodos(), hasFocus(), and focus() methods |
| src/vs/workbench/contrib/chat/browser/actions/chatActions.ts | Registered new command with preconditions for agent chat mode and imported aria alert utility |
| src/vs/workbench/contrib/chat/browser/actions/chatAccessibilityHelp.ts | Added accessibility help text explaining the new toggle focus command |
| src/vs/workbench/contrib/chat/test/browser/chatTodoListWidget.test.ts | Added tests for focus expansion behavior and hasTodos() visibility reporting |
src/vs/workbench/contrib/chat/browser/actions/chatAccessibilityHelp.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…yHelp.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #281597
todos.mov