Make recursive search for AGENTS.md case-insensitive #283116
Draft
+56
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the recursive search for AGENTS.md files case-insensitive by updating the glob pattern to use character classes. This ensures that instruction files with various casings (e.g., 'agents.md', 'Agents.md', 'AGENTS.MD') are discovered, improving the robustness of the agent instruction file detection feature.
Key changes:
- Updated file pattern from
**/AGENTS.mdto**/[Aa][Gg][Ee][Nn][Tt][Ss].[Mm][Dd]to support case-insensitive matching - Added explanatory comment documenting the workaround approach
src/vs/workbench/contrib/chat/common/promptSyntax/utils/promptFilesLocator.ts
Show resolved
Hide resolved
Contributor
* Initial plan * Add test for case-insensitive AGENTS.md file search Co-authored-by: jruales <1588988+jruales@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jruales <1588988+jruales@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #276773