Preserve search listeners after replace (fix #282773) #283061
+15
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution Summary for #282773
Problem: After Replace All, calling clear() disposed all file match objects and their model listeners, so when users undo, the changes weren't detected and the Replace All button stayed disabled.
Solution: Remove the clear() call and instead force immediate match updates via forceUpdateMatches(), which:
Trade-off: Slightly slower with large result sets (requires re-searching files) compared to the instant clear(), but necessary to maintain the infrastructure for undo detection.