no config debug: Fix error when multiple vscode windows are open #918
+13
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix microsoft#916, but getting this installed locally seemed sufficiently complicated that I gave up. Fix is: 1. Only watch a specific endpoint file 2. Make sure this endpoint file is unique (I imagine the workspace file path can be non unique across vscode windows)
rchiodo
previously approved these changes
Jan 8, 2026
Contributor
|
Whoops, didn't meant to close this. @Zentrik it looks like this is causing a bunch of test failures. |
I guess this is what I get for trusting AI at midnight.
The error seems to be that `base` is `c:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\.noConfigDebugAdapterEndpoints` but `noConfigEndpointDir` is `C:\Users\RUNNER~1\AppData\Local\Temp\.noConfigDebugAdapterEndpoints` (the C is capitalised). Getting the fsPath of the URI should normalise the path the same as `base`.
Author
Sorry about that, thanks for reviewing. I think it should be fixed now, o/w will have to wait till tmrw and I'll boot into windows to debug further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #916,
but getting this installed locally seemed sufficiently complicated that I gave up. I figured out the nox stuff, I tested with two windows and this worked.Fix is: