Conversation
package.json
Outdated
| "dark": "#FFD9FE", | ||
| "light": "#FFD9FE", | ||
| "highContrast": "editor.foreground", | ||
| "highContrastLight": "editor.foreground" |
There was a problem hiding this comment.
I'm happy for these to be customizable, but in general it's good to make the colors derive from an existing color. In this case, I think all 4 options here (and for the other new colors) should derive from the current color: button.foreground. This will create the least amount of disruption for users, and give an opportunity to for the color to be automatically configured to something that makes sense with their theme.
There was a problem hiding this comment.
If it's better in your theme, I would also be fine with button.secondaryForeground.
There was a problem hiding this comment.
Thanks for the review, and great point! I'll make them as such!
There was a problem hiding this comment.
I was thinking, and what about using the original GitHub colors to look exactly like the website? Background colors refer to them, so why not the foregrounds?
There was a problem hiding this comment.
If you're referring to the open, merged, and draft background colors then matching the website is fine if we don't already do it. I would have to double check and make sure that the colors don't look odd in the default VS Code dark and light themes.
For the foreground, I think it's just black or white on github.com, isn't it?
There was a problem hiding this comment.
Yeah and I thought we could default to white/black instead of button foreground since the background color is fixed, it would be dangerous to let the foreground be what the theme says (it will break everywhere)
There was a problem hiding this comment.
I see now, thanks for elaborating! Yes, this makes sense. I would suggest just one new color to use for all three status badges then: pullRequests.statusForeground.
There was a problem hiding this comment.
Can we please have the option to customize all of them (because it would make at least my theme much more pretty) and have all of them default to this color?
There was a problem hiding this comment.
Sure, that's fine for me. Let's have pullRequests.statusOpenForeground, then have the other pullRequests.status*Foreground values default to pullRequests.statusOpenForeground.
There was a problem hiding this comment.
Sure thing, I'll apply it now
|
@alexr00 I have applied the changes you requested, I hope you find them acceptable. |
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
@pouyakary the light/dark colors were inverted, so I've swapped them. I also saw that the color wasn't being applied and fixed that too. Looks like the color is still missing from the icon in the badge.
|
Oh, sorry :( Let me see if I can fix it |
This comment was marked as spam.
This comment was marked as spam.
1 similar comment
This comment was marked as spam.
This comment was marked as spam.
3 participants
This PR adds foregrounds colors for the PR badges which fixes #5622