[python] Remove dead TypingSection.CONDITIONAL enum value #9667
+33
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CONDITIONAL was a legacy concept for Python 2 compatibility. It was intended to place imports under TYPE_CHECKING for Python 2 files and as regular imports for Python 3 files. Since Python 2 support has been dropped, CONDITIONAL was always treated identically to REGULAR. - Remove CONDITIONAL from TypingSection enum - Replace all TypingSection.CONDITIONAL usages with TypingSection.REGULAR - Simplify FileImportSerializer._get_imports_list by removing the conditional merging logic
msyyc
changed the title
microsoft-github-policy-service
bot
added
the
emitter:client:python
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
Collaborator
|
You can try these changes here
|
msyyc
requested review from
catalinaperalta,
iscai-msft,
lmazuel,
mccoyp,
swathipil,
tadelesh and
timotheeguerin
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #9529
Summary
Remove the
TypingSection.CONDITIONALenum value from the Python code generator. This was a legacy concept for Python 2 compatibility that is no longer needed.Background
CONDITIONALwas intended to place imports underTYPE_CHECKINGfor Python 2 files and as regular imports for Python 3 files. Since Python 2 support has been dropped,CONDITIONALwas always treated identically toREGULAR— there was no code path that ever placed it underTYPE_CHECKING.Changes
imports.py— RemovedCONDITIONALfromTypingSectionenumimport_serializer.py— Simplified_get_imports_listby removing the conditional merging logic (20 lines → 2 lines)TypingSection.CONDITIONALreferences withTypingSection.REGULARNet result: -21 lines of dead code removed.
Validation