Port TypeScript PR #63054: Default types to [], support "*" wildcard#2688
Open
Port TypeScript PR #63054: Default types to [], support "*" wildcard#2688
types to [], support "*" wildcard#2688Conversation
… `"*"` wildcard Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Port TypeScript pull request 63054
Port TypeScript PR #63054: Default Feb 5, 2026
types to [], support "*" wildcard
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ports TypeScript PR #63054, implementing a breaking change where types defaults to [] (no auto-discovery) instead of discovering all @types packages. Users must explicitly use types: ["*"] to enable the previous auto-discovery behavior.
Changes:
- Added
UsesWildcardTypes()method to check iftypescontains"*" - Modified automatic type directive resolution to handle wildcard substitution
- Swapped diagnostic messages to recommend adding to
typesfield when wildcards are NOT in use - Updated test baselines to reflect new error messages (TS2580→TS2591, TS2581→TS2592, etc.)
Reviewed changes
Copilot reviewed 156 out of 156 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
internal/core/compileroptions.go |
Added UsesWildcardTypes() helper method |
internal/module/resolver.go |
Updated GetAutomaticTypeDirectiveNames() to handle wildcard expansion and return empty array by default |
internal/checker/checker.go |
Inverted diagnostic message logic - now suggests adding to types when NO wildcard |
internal/compiler/fileInclude.go |
Updated to use UsesWildcardTypes() instead of checking Types != nil |
testdata/baselines/reference/** |
Updated test baselines reflecting new default behavior |
internal/fourslash/_scripts/failingTests.txt |
Removed 3 tests that now pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports microsoft/TypeScript#63054. Changes default behavior: when
typesis unset, no@typespackages are auto-discovered. Usetypes: ["*"]for the previous behavior.Core Changes
internal/core/compileroptions.go: AddUsesWildcardTypes()method—returns true iftypescontains"*"internal/module/resolver.go: UpdateGetAutomaticTypeDirectiveNames():typesdirectly (or[]if nil)"*"with discovered packages, deduplicateinternal/checker/checker.go: Swap diagnostic message selection logic—now suggests adding totypeswhen wildcards are NOT in useinternal/compiler/fileInclude.go: Update automatic type directive file diagnostics to use new wildcard checkExample
Test Updates
typesfield instructions)failingTests.txt—depend on old auto-discovery behavior, will resolve when TypeScript submodule updatesOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.