Python: Fix GoogleAI validation: skip API key check when using Vertex AI#13518
Open
veeceey wants to merge 1 commit intomicrosoft:mainfrom
Open
Python: Fix GoogleAI validation: skip API key check when using Vertex AI#13518veeceey wants to merge 1 commit intomicrosoft:mainfrom
veeceey wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13483 - GoogleAIChatCompletion now correctly skips API key validation when
use_vertexai=True.Changes
api_keywhenuse_vertexaiisFalseTest Plan
test_google_ai_chat_completion_init_with_vertexai_without_api_keyto verify the fixuse_vertexai=Falseuse_vertexai=TrueThe validation logic now correctly differentiates between:
use_vertexai=True): Requiresproject_id, API key is optional (uses ADC)use_vertexai=False): Requiresapi_key