chore: support config in cli #38947

pavelfeldman · 2026-01-24T21:11:29Z

Fixes: microsoft/playwright-cli#209
Fixes: microsoft/playwright-cli#210

packages/playwright/src/mcp/browser/config.ts

packages/playwright/src/mcp/terminal/daemon.ts

packages/playwright/src/mcp/terminal/helpGenerator.ts

github-actions · 2026-01-25T02:59:19Z

Test results for "tests 1"

3 failed
❌ [playwright-test] › reporter.spec.ts:251 › created › should not have internal error when steps are finished after timeout @macos-latest-node20
❌ [playwright-test] › test-step.spec.ts:369 › should not pass return value from step @macos-latest-node20
❌ [playwright-test] › to-have-screenshot.spec.ts:98 › should not retry serial mode suites with missing expectation errors @macos-latest-node20

1 flaky

⚠️ [playwright-test] › runner.spec.ts:124 › should ignore subprocess creation error because of SIGINT `@macos-latest-node20`

33892 passed, 691 skipped

Merge workflow run.

github-actions · 2026-01-25T03:03:02Z

Test results for "MCP"

33 failed
❌ [chrome] › mcp/cli.spec.ts:275 › save as › screenshot --full-page @mcp-ubuntu-latest
❌ [chrome] › mcp/cli.spec.ts:433 › session › session-stop-all @mcp-ubuntu-latest
❌ [chromium] › mcp/cli.spec.ts:350 › devtools › tracing-start-stop @mcp-ubuntu-latest
❌ [chromium] › mcp/cli.spec.ts:433 › session › session-stop-all @mcp-ubuntu-latest
❌ [firefox] › mcp/cli.spec.ts:433 › session › session-stop-all @mcp-ubuntu-latest
❌ [firefox] › mcp/cli.spec.ts:458 › session › session-delete named session @mcp-ubuntu-latest
❌ [webkit] › mcp/cli.spec.ts:275 › save as › screenshot --full-page @mcp-ubuntu-latest
❌ [webkit] › mcp/cli.spec.ts:433 › session › session-stop-all @mcp-ubuntu-latest
❌ [webkit] › mcp/snapshot-mode.spec.ts:58 › should respect --snapshot-mode=incremental @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:310 › devtools › console --clear @mcp-macos-15
❌ [chrome] › mcp/cli.spec.ts:328 › devtools › network --static @mcp-macos-15
❌ [chrome] › mcp/cli.spec.ts:335 › devtools › network --clear @mcp-macos-15
❌ [chrome] › mcp/cli.spec.ts:433 › session › session-stop-all @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:218 › keyboard › keydown keyup @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:238 › mouse › mousedown mouseup @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:267 › save as › screenshot @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:275 › save as › screenshot --full-page @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:300 › devtools › console error @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:372 › config › context options @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:433 › session › session-stop-all @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:447 › session › session-delete @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:458 › session › session-delete named session @mcp-macos-15
❌ [chromium] › mcp/launch.spec.ts:79 › persistent context @mcp-macos-15
❌ [firefox] › mcp/cli.spec.ts:238 › mouse › mousedown mouseup @mcp-macos-15
❌ [firefox] › mcp/cli.spec.ts:267 › save as › screenshot @mcp-macos-15
❌ [firefox] › mcp/cli.spec.ts:310 › devtools › console --clear @mcp-macos-15
❌ [firefox] › mcp/cli.spec.ts:335 › devtools › network --clear @mcp-macos-15
❌ [firefox] › mcp/cli.spec.ts:433 › session › session-stop-all @mcp-macos-15
❌ [webkit] › mcp/cli.spec.ts:310 › devtools › console --clear @mcp-macos-15
❌ [webkit] › mcp/cli.spec.ts:328 › devtools › network --static @mcp-macos-15
❌ [webkit] › mcp/cli.spec.ts:335 › devtools › network --clear @mcp-macos-15
❌ [webkit] › mcp/cli.spec.ts:433 › session › session-stop-all @mcp-macos-15
❌ [webkit] › mcp/snapshot-mode.spec.ts:58 › should respect --snapshot-mode=incremental @mcp-macos-15

3169 passed, 360 skipped

Merge workflow run.

yury-s · 2026-01-25T03:20:56Z

packages/playwright/src/mcp/terminal/program.ts

+        console.log(`Deleted user data for session '${sessionName}'.`);
+        break;
+      } catch (e: any) {
+        await new Promise(resolve => setTimeout(resolve, 1000));


move this after line 170?

yury-s · 2026-01-25T03:28:28Z

packages/playwright/src/mcp/terminal/program.ts

+
+  try {
+    if (fs.existsSync(path.resolve(process.cwd(), 'playwright-cli.json')))
+      return path.resolve(process.cwd(), 'playwright-cli.json');


nit: do path.resolve(process.cwd(), 'playwright-cli.json'); only once?

yury-s · 2026-01-25T03:33:19Z

packages/playwright/src/mcp/terminal/program.ts

+      return `\\\\.\\pipe\\${installationDirHash}-${socketName}`;
+    if (process.env.PLAYWRIGHT_DAEMON_SOCKET_DIR)
+      return path.join(process.env.PLAYWRIGHT_DAEMON_SOCKET_DIR, socketName);
+    return path.join(os.tmpdir(), 'playwright-cli', installationDirHash, socketName);


what about already running daemons with old socket path, just leak?

yury-s · 2026-01-25T03:36:21Z

packages/playwright/src/mcp/browser/browserContextFactory.ts

      ...this.config.browser.launchOptions,
      handleSIGINT: false,
      handleSIGTERM: false,
-      ...(options.forceHeadless !== undefined ? { headless: options.forceHeadless === 'headless' } : {}),


Does launching headed mode still work when there is an existing headless session?

This comment has been minimized.

Sign in to view

dgozman approved these changes Jan 24, 2026

View reviewed changes

packages/playwright/src/mcp/browser/config.ts Outdated Show resolved Hide resolved

packages/playwright/src/mcp/terminal/daemon.ts Outdated Show resolved Hide resolved

packages/playwright/src/mcp/terminal/helpGenerator.ts Outdated Show resolved Hide resolved

pavelfeldman force-pushed the cli_config branch 2 times, most recently from 62f06e5 to 26fdc09 Compare January 25, 2026 01:27

This comment has been minimized.

Sign in to view

pavelfeldman force-pushed the cli_config branch from 26fdc09 to fa9d60d Compare January 25, 2026 01:41

This comment has been minimized.

Sign in to view

pavelfeldman force-pushed the cli_config branch from fa9d60d to 7cdfc0c Compare January 25, 2026 02:20

chore: allow for the structured reply in mcp

58e552b

pavelfeldman force-pushed the cli_config branch from 7cdfc0c to 58e552b Compare January 25, 2026 02:23

microsoft deleted a comment from github-actions bot Jan 25, 2026

yury-s approved these changes Jan 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: support config in cli #38947

chore: support config in cli #38947

pavelfeldman commented Jan 24, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 25, 2026

Uh oh!

github-actions bot commented Jan 25, 2026

Uh oh!

yury-s Jan 25, 2026

Uh oh!

yury-s Jan 25, 2026

Uh oh!

yury-s Jan 25, 2026

Uh oh!

yury-s Jan 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chore: support config in cli #38947

Are you sure you want to change the base?

chore: support config in cli #38947

Conversation

pavelfeldman commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 25, 2026

Test results for "tests 1"

Uh oh!

github-actions bot commented Jan 25, 2026

Test results for "MCP"

Uh oh!

yury-s Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

yury-s Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

yury-s Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

yury-s Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pavelfeldman commented Jan 24, 2026 •

edited

Loading