Added test fixture for Browser.NewContextOptions

[uchagani]

Resolves #1781

[yury-s]

Perhaps we should support this for Browser.NewPageOptions too as browser.newPage() is essentially a shortcut for newContext followed by newPage.

[yury-s]

Looks like the new tests are failing.

[uchagani]

yea i need to figure out what's going. they pass locally for me

[uchagani]

@yury-s can we re-run? looks like they're mostly failing to connect to the test server

[yury-s]

Restarted the jobs.

[uchagani]

@yury-s I'm trying to fix these tests and running into an odd issue. When the base url is set to http://localhost:9066/empty.html via

  public static class CustomOptions implements OptionsFactory {
    @Override
    public Options getOptions() {
      System.out.println("Empty Page URL: " + serverMap.get(TestFixtureContextOptions.class).EMPTY_PAGE);

      return new Options()
        .setApiRequestOptions(new APIRequest.NewContextOptions()
          .setBaseURL(serverMap.get(TestFixtureContextOptions.class).EMPTY_PAGE))
        .setContextOptions(new Browser.NewContextOptions()
          .setBaseURL(serverMap.get(TestFixtureContextOptions.class).EMPTY_PAGE));
    }
  }

and I run page.navigate("/");

I will get the error:

23:47:52 [ERROR]   TestFixtureContextOptions.testCustomBrowserContext:49 » Playwright Error {
  message='Protocol error (Page.navigate): Cannot navigate to invalid URL
  name='Error
  stack='Error: Protocol error (Page.navigate): Cannot navigate to invalid URL

Is this not supported?

[uchagani]

Also this only happens when I'm running all tests together.

I've verified via logging that the URL used in the options is the same as the url in the test.

Might need to do more digging. Maybe some race condition with the httpserver

[yury-s]

Yeah, sounds like a race condition. I'd check with DEBUG=pw:protocol to see what's being sent to the browser. My hunch is that sometimes it sends just '/' instead of the the base url.