Improve names of .node files

[Bashamega]

fix #701

[Tyriar]

Is it target_name we need to change as well to change the .node file, then an update here is needed too:

node-pty/src/windowsPtyAgent.ts

Lines 64 to 93 in 467cea0

	if (!conptyNative) {
	try {
	conptyNative = require('../build/Release/conpty.node');
	} catch (outerError) {
	try {
	conptyNative = require('../build/Debug/conpty.node');
	} catch (innerError) {
	console.error('innerError', innerError);
	// Re-throw the exception from the Release require if the Debug require fails as well
	throw outerError;
	}
	}
	}
	} else {
	if (!winptyNative) {
	try {
	winptyNative = require('../build/Release/pty.node');
	} catch (outerError) {
	try {
	winptyNative = require('../build/Debug/pty.node');
	} catch (innerError) {
	console.error('innerError', innerError);
	// Re-throw the exception from the Release require if the Debug require fails as well
	throw outerError;
	}
	}
	}
	}
	this._ptyNative = this._useConpty ? conptyNative : winptyNative;

[Bashamega]

Thank you. I will update it

[Bashamega]

Done :)

[Tyriar]

We just need to figure out why CI is failing now. See the error at https://dev.azure.com/vscode/node-pty/_build/results?buildId=147363&view=logs&j=0bc77094-9fcd-5c38-f6e4-27d2ae131589&t=2917e7a9-bb9d-585b-890e-1ad69b6f3f65&l=976

[deepak1556]

Name should be updated in

node-pty/scripts/post-install.js

Lines 10 to 11 in 090384f

	path.join(RELEASE_DIR, 'conpty.node'),
	path.join(RELEASE_DIR, 'conpty.pdb'),

to fix the build error.

[Bashamega]

Thank you

[Bashamega]

Hello @deepak1556
I have updated the post-install script, but it is still not working.

[deepak1556]

Please check #768 (comment)

[Bashamega]

Hello @Tyriar
I don't know why it is not working, it is working on Linux and Mac.
I don't know c++ or how this project is built.
Can you help me?
Thanks.

[Tyriar]

That error means that the expected compile .node file isn't there, so the change in binding.gyp didn't seem to do the right file or something. I don't have time to look into this further atm unfortunately.

[Bashamega]

That error means that the expected compile .node file isn't there, so the change in binding.gyp didn't seem to do the right file or something. I don't have time to look into this further atm unfortunately.

I will try to look at it more

[deepak1556]

changing the target name is sufficient to achieve the required result, lets keep the source file names unchanged.

[Bashamega]

Okay

[deepak1556]

Not required for the scope of this PR, lets revert this.

[deepak1556]

These should not be renamed, they are prebuilt binaries from conpty library.

[deepak1556]

There is one another place to update

node-pty/src/win/conpty.cc

Line 171 in bfbd943

HMODULE hModule = GetModuleHandleA("conpty.node");

and that should fix the failing tests.