Skip to content

Conversation

@darstahl
Copy link

@darstahl darstahl commented Jan 9, 2018

Updating dotnet installer to use the ps1 install script and updating the SDK to 2.0.

This fixes CI issues found in #24

Signed-off-by: Darren Stahl darst@microsoft.com

Signed-off-by: Darren Stahl <darst@microsoft.com>
@darstahl darstahl force-pushed the AppveyorInstall branch 2 times, most recently from 283cb35 to 0faf59c Compare January 10, 2018 01:28
@darstahl
Copy link
Author

@jterry75 @swernli PTAL this fixes CI

@darstahl darstahl changed the title Update dotnet install to use ps1 script Update to 2.0 SDK Jan 10, 2018
@darstahl darstahl added the bug label Jan 10, 2018
@jterry75
Copy link
Contributor

Nice @darrenstahlmsft - Only feedback I have is that I led you astray. You will want to still call dotnet build because the dotnet pack that you are calling only validates the build of the actual dll. It doesn't compile any of the samples or tests so a change here could break the build.

@darstahl darstahl force-pushed the AppveyorInstall branch 2 times, most recently from 8a6f506 to bcf1d89 Compare January 10, 2018 21:13
@darstahl
Copy link
Author

Added samples to the SLN file and added back the dotnet build step to compile them in CI.

Signed-off-by: Darren Stahl <darst@microsoft.com>
@darstahl
Copy link
Author

Also pushed a fix to the build warning by adding a reference to Microsoft.Extensions.DependencyModel 1.1.0

@jterry75
Copy link
Contributor

LGTM

@jterry75 jterry75 merged commit 78b4d29 into microsoft:master Jan 10, 2018
@darstahl darstahl deleted the AppveyorInstall branch January 10, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants