step / init / execute_action #315
Open
+189
−161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fix terminated flag overwrite bug (env.py:440-463) - Added early return after catching UnrecoverableTerminalError - Prevents terminated=True from being overwritten by calculate_terminated() 2. Add UnrecoverableTerminalError handling in EventHooks.notify() (env.py:112-114) - Re-raises UnrecoverableTerminalError so it propagates to the environment - Prevents fatal terminal errors from being silently converted to observations 3. Add exc_info=True to logger.error (env.py:439) - Logs the full stack trace for debugging production issues 4. Remove stray test lines in test_kubernetes.py - Removed 7 lines accidentally left from original test function 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Clear exc_info and exc_text from log records before putting them in the multiprocessing queue, since traceback objects cannot be pickled. The local handler processes the record first (with full exception info for file logging), then we strip unpicklable parts before sending to the main process. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add setup_commands support to EnvironmentTool base class - Setup commands run via on_env_reset() for tools added before reset - Setup commands run immediately in register() for tools added after reset - Simplify ListdirTool to just declare setup_commands attribute - Remove collect_tool_setup_commands() from experiment.py (now handled by event system) - Add tests for setup_commands functionality 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix llm instantiate weird thing * add message to submit tool * update tests * update configs * remove llm config file from llm init func ... * list for type? * remove required * mark\ comment --------- Co-authored-by: Alessandro Sordoni <alsordon@microsoft.com> Co-authored-by: Marc-Alexandre Côté <marc.cote.19@gmail.com>
MarcCote
requested changes
Dec 13, 2025
Collaborator
MarcCote
left a comment
MarcCote
left a comment
There was a problem hiding this comment.
move back the run in agent.run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some cleanup: