fix: Remove RHEL Build Requirement for Rust#15754
fix: Remove RHEL Build Requirement for Rust#15754Tonisal-byte wants to merge 5 commits intotomls/base/mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR moves Rust customization into a dedicated component file and disables the RHEL-specific rust-toolset build requirement via an overlay, aligning with the repo’s pattern of putting customized components under their own directories.
Changes:
- Added a
base/comps/rust/rust.comp.tomlcomponent definition with a spec overlay that removes%{?rhel:BuildRequires: rust-toolset}. - Removed the inline
[components.rust]entry frombase/comps/components.toml(now sourced viaincludes = ["**/*.comp.toml"]).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| base/comps/rust/rust.comp.toml | Defines the Rust component overlay to remove the RHEL-only rust-toolset BuildRequires line. |
| base/comps/components.toml | Drops the old components.rust stub entry since Rust is now defined via the included .comp.toml. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
reubeno
left a comment
There was a problem hiding this comment.
Let's hold off merging this until we can sort out whether the surgical overlay here is the Right fix to make.
base/comps/rust/rust.comp.toml
Outdated
There was a problem hiding this comment.
While this gets it to build, what's the impact of enabling all of the other blocks in the .spec conditional on rhel being defined (and/or a certain value)?
Let's sort out if the correct decision is to ensure that rhel is undefined for this spec. If that's the right call, we may need a new way to express that via the TOML files.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Disables
rust-toolsetbuild requirementChange Log
Does this affect the toolchain?
It does not.
Test Methodology
Successfully completed builds on stable koji deployment.