Enable Local File Sources in Provider Discovery #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two issues fixed: 1. _discover_providers_from_sources() only handled git URLs, causing local file source overrides (file://, ./, ../, /) to silently fail during provider discovery. This meant providers with local sources wouldn't appear in `amplifier init` selection. 2. list_providers() only used source discovery as a fallback when no entry points were found. Local source providers were invisible when other providers had entry points registered. 3. use_provider() used DEFAULT_PROVIDER_SOURCES instead of effective sources, causing local file overrides to be replaced with git URLs when saving provider configuration. Changes: - Rename _is_local_path to is_local_path and export it - Add FileSource handling in _discover_providers_from_sources() - Make list_providers() merge entry points with source discovery - Make use_provider() use get_effective_provider_sources() 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Prevents AttributeError when __file__ is None in certain import contexts. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the installed version of Amplifier (via pip install or uv tool install), users
could only configure providers in ~/.amplifier/settings.yaml with git sources. Local file
paths were not supported in the provider discovery and configuration system, making it
difficult to:
This limitation only affected the global settings configuration - local project configs worked
fine with file sources.
Solution
This PR adds support for local file sources in the provider discovery and configuration
system:
file:///path/to/provider, /absolute/path, ./relative/path)
sources in settings.yaml
AttributeError in certain import contexts