-
Notifications
You must be signed in to change notification settings - Fork 1k
.NET: Make ChatMessageStore and AIContextProvider context props settable #3196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR makes properties on context parameter classes settable to enable filter clauses without requiring full context cloning. The change supports the existing ChatMessageStoreMessageFilter pattern where filter functions need to modify context properties.
Changes:
- Made
RequestMessagesproperty settable onInvokingContextclasses in bothChatMessageStoreandAIContextProvider - Made
RequestMessagesandChatMessageStoreMessagesproperties settable onChatMessageStore.InvokedContext - Made
RequestMessagesandAIContextProviderMessagesproperties settable onAIContextProvider.InvokedContext
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI.Abstractions/ChatMessageStore.cs | Changed 3 properties from get-only to get/set to enable filter modifications |
| dotnet/src/Microsoft.Agents.AI.Abstractions/AIContextProvider.cs | Changed 3 properties from get-only to get/set to enable filter modifications |
dotnet/src/Microsoft.Agents.AI.Abstractions/ChatMessageStore.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Microsoft.Agents.AI.Abstractions/ChatMessageStore.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Microsoft.Agents.AI.Abstractions/ChatMessageStore.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Microsoft.Agents.AI.Abstractions/AIContextProvider.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Microsoft.Agents.AI.Abstractions/AIContextProvider.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Motivation and Context
#3194
Description
Contribution Checklist