.NET: [Breaking] Rename AgentRunResponse{Update} to AgentResponse{Update} #2949
Conversation
markwallace-microsoft
added
documentation
There was a problem hiding this comment.
Pull request overview
This pull request implements a systematic renaming of AgentRunResponse and AgentRunResponseUpdate to AgentResponse and AgentResponseUpdate respectively, addressing issue #2899. The changes are clean and consistent across the entire codebase.
Key Changes:
- Renamed core types:
AgentRunResponse→AgentResponseandAgentRunResponseUpdate→AgentResponseUpdate - Updated all extension methods and helper methods to use the new naming (e.g.,
ToAgentRunResponse()→ToAgentResponse()) - Updated XML documentation comments, error messages, and inline documentation to reflect the new naming
- Removed BOM (Byte Order Mark) characters from copyright headers across all modified files
Reviewed changes
Copilot reviewed 181 out of 181 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Test files (40+ files) | Systematically updated all test classes, methods, and variable declarations to use new type names |
| Source abstractions | Core AgentResponse.cs and AgentResponseUpdate.cs files renamed with all references updated |
| Extension methods | AgentResponseExtensions.cs updated with all conversion methods renamed appropriately |
| AIAgent implementations | All agent implementations (DurableTask, CopilotStudio, A2A, Workflows, Purview, etc.) updated consistently |
| Hosting implementations | OpenAI and AzureFunctions hosting layers updated with new type names |
| Sample code | All sample programs updated to demonstrate proper usage with new naming |
| Documentation | README files and inline documentation updated to reference new type names |
| Declarative workflows | Generated code templates and workflow executors updated |
The renaming is thorough, consistent, and maintains backward compatibility in terms of functionality while improving API clarity by removing the redundant "Run" term from the response type names.
|
@feiyun0112, thanks for the contribution. Do you mind resolving the conflicts so we can procced with this PR? |
SergeyMenshykh
changed the title
dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/AgentResponseExtensions.cs
Outdated
Show resolved
Hide resolved
|
@alliscode, @lokitoth I wonder if we need to rename |
feiyun0112
temporarily deployed
to
integration
GitHub Actions
Inactive
feiyun0112
temporarily deployed
to
integration
GitHub Actions
Inactive
|
@feiyun0112, the dotnet-format check fails with "/app/dotnet/samples/AGUIClientServer/AGUIClient/Program.cs(1,1): error CHARSET: Fix file encoding. [/app/dotnet/samples/AGUIClientServer/AGUIClient/AGUIClient.csproj]" error; please have a look. |
feiyun0112
temporarily deployed
to
integration
GitHub Actions
Inactive
feiyun0112
temporarily deployed
to
integration
GitHub Actions
Inactive
feiyun0112
temporarily deployed
to
integration
GitHub Actions
Inactive
feiyun0112
temporarily deployed
to
integration
GitHub Actions
Inactive
| @@ -1,4 +1,4 @@ | |||
| // Copyright (c) Microsoft. All rights reserved. | |||
| // Copyright (c) Microsoft. All rights reserved. | |||
There was a problem hiding this comment.
This change should be reverted.
| @@ -1,4 +1,4 @@ | |||
| // Copyright (c) Microsoft. All rights reserved. | |||
| // Copyright (c) Microsoft. All rights reserved. | |||
There was a problem hiding this comment.
This change should be reverted.
| @@ -1,4 +1,4 @@ | |||
| // ------------------------------------------------------------------------------ | |||
| // ------------------------------------------------------------------------------ | |||
There was a problem hiding this comment.
This change should be reverted.
| @@ -1,4 +1,4 @@ | |||
| // ------------------------------------------------------------------------------ | |||
| // ------------------------------------------------------------------------------ | |||
There was a problem hiding this comment.
This change should be reverted.
| @@ -1,4 +1,4 @@ | |||
| // Copyright (c) Microsoft. All rights reserved. | |||
| // Copyright (c) Microsoft. All rights reserved. | |||
There was a problem hiding this comment.
This change should be reverted.
| @@ -1,4 +1,4 @@ | |||
| // Copyright (c) Microsoft. All rights reserved. | |||
| // Copyright (c) Microsoft. All rights reserved. | |||
There was a problem hiding this comment.
This change and similar change in several files below should be reverted.
|
@feiyun0112, I'm proceeding with this PR #3197 instead since it blocks the other renaming work we want to do asap. |
4 participants
fix #2899