Support additionalType #2279
Merged
Support additionalType #2279
+42
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
saschanaz
reviewed
Dec 9, 2025
src/build/patches.ts
Outdated
| function handleAdditionalTypes(node: Node) { | ||
| const additionalTypes = []; | ||
| for (const child of node.children) { | ||
| if (child.name === "additionalType") { |
Collaborator
There was a problem hiding this comment.
This is assuming to repeat like
additionalType foo
additionalType bar
right? But maybe just additionalTypes foo bar, because it's always just a simple string?
Contributor
Author
|
I have updated it @saschanaz, and added a sample for multiple additionaltypes |
saschanaz
reviewed
Dec 13, 2025
saschanaz
reviewed
Dec 13, 2025
Contributor
Author
|
I have fixed the broken code @saschanaz |
Collaborator
|
LGTM, thanks! |
Contributor
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.