Running shell commands using the user's shell#3884
Open
htogta wants to merge 3 commits intomicro-editor:masterfrom
Open
Running shell commands using the user's shell#3884htogta wants to merge 3 commits intomicro-editor:masterfrom
htogta wants to merge 3 commits intomicro-editor:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant to this issue.
Added a function to
shell.goto fetch what the user's current shell is in order to use that to execute shell commands. This allows for the use of|and&&when doing theruncommand orCtrl-bwhich you couldn't do before.Also reworked some of the code for the
runcommand to no longer use the shellquote join function, as it would escape characters like&when we didn't necessarily want it to, and removed the no-longer-necessary shellquote Split function call from the shell'sRunCommandfunction.This fix could potentially use some more work- for example, it assumes that the user's shell uses the posix-style
-cflag which certain shells might not use.