Fix max lenght in UDP port string

[pablogs9]

No description provided.

[pablogs9]

@mergify backport iron humble

[mergify]

backport iron humble

✅ Backports have been created

Details

• #316 Fix max lenght in UDP port string (backport #315) has been created for branch iron
• #317 Fix max lenght in UDP port string (backport #315) has been created for branch humble but encountered conflicts

[jimmy-mcelwain]

I think that this is going to have a bit of a problem too, but less important. The strlen(port) <= MAX_PORT_LEN in the condition is going to return true if the length of the port is 6, now, meaning it will truncate the 6 digit port (invalid) into a 5 digit port (valid). It should still return RMW_RET_INVALID_ARGUMENT though.

[pablogs9]

@jimmy-mcelwain looks good to you now?

[jimmy-mcelwain]

It looks like you modified the condition for MAX_IP_LEN rather than MAX_PORT_LEN. Maybe some change is needed in the IP side since it is using snprintf too (I don't know, I haven't looked into that), but I think that change was probably supposed to be for the strlen(port) <= MAX_PORT_LEN that I mentioned before.

[jimmy-mcelwain]

It looks like it may need to change here too:

rmw_microxrcedds/rmw_microxrcedds_c/src/rmw_init.c

Lines 95 to 102 in 554445f

	if (strlen(RMW_UXRCE_DEFAULT_PORT) <= MAX_PORT_LEN) {
	snprintf(
	init_options->impl->transport_params.agent_port,
	MAX_PORT_LEN, "%s", RMW_UXRCE_DEFAULT_PORT);
	} else {
	RMW_UROS_TRACE_MESSAGE("default port configuration overflow")
	return RMW_RET_INVALID_ARGUMENT;
	}

[pablogs9]

Thanks, sorry, today I'm very busy and I guess that this PR requires more attention from my side...
The CI is failing due to a cpplint & uncrustify incompatibility.
If now we are ok with that, I can merge.

[jimmy-mcelwain]

No problem at all, I appreciate the quick response. I don't have a easy way of testing/verifying that these changes work at the moment, but just looking at the code I don't see anything wrong.

[jimmy-mcelwain]

Thanks!

[jimmy-mcelwain]

@pablogs9 I just realized that this was backported to humble and iron. Shouldn't it be backported to jazzy too (instead of iron)?

[pablogs9]

@mergify backport jazzy

[mergify]

backport jazzy

✅ Backports have been created

Details

• #320 Fix max lenght in UDP port string (backport #315) has been created for branch jazzy but encountered conflicts

[pablogs9]

@pablogs9 I just realized that this was backported to humble and iron. Shouldn't it be backported to jazzy too (instead of iron)?

done

[jimmy-mcelwain]

Thank you!