Improve duplicate suppression hot paths and remove redundant outbound queue scans#1774
Open
robekl wants to merge 2 commits intomeshcore-dev:devfrom
Open
Improve duplicate suppression hot paths and remove redundant outbound queue scans#1774robekl wants to merge 2 commits intomeshcore-dev:devfrom
robekl wants to merge 2 commits intomeshcore-dev:devfrom
Conversation
…lters Cache packet SHA256 values on Packet instances and invalidate the cache whenever mutable packet state changes before queueing or loopback replay. Add compact bitmap prefilters for hash-prefix and ACK low-byte lookups so unseen keys bypass full table scans, while preserving existing exact-match checks. This keeps memory static, avoids false negatives, and reduces repeated CPU work in duplicate suppression hot paths.
Simplify send scheduling by removing the pre-check outbound count scan and relying on a single getNextOutbound() lookup. This eliminates repeated linear queue traversal in the hot path while preserving CAD gating, silence timing, and packet-send behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies two focused performance improvements in packet processing and scheduling paths.
What changed
1) Packet-hash caching with faster duplicate-table prefiltering
2) Outbound scheduler no-double-scan path
Why this is beneficial
Reviewer-focused implementation notes