[WIP] Add pipeline, server, socket and strip key prefix options#3
Open
feihu-stripe wants to merge 2 commits intomemcached:masterfrom
Open
[WIP] Add pipeline, server, socket and strip key prefix options#3feihu-stripe wants to merge 2 commits intomemcached:masterfrom
feihu-stripe wants to merge 2 commits intomemcached:masterfrom
Conversation
Member
|
Looks awesome! |
Member
|
What else would you like to fix here before merging? Note that this thing was probably my second Golang program, and I don't think I even had gofmt running properly. If you let me know what could help on making this thing more collaboration-friendly I'll get right on that. I hope to rely on it as a test suite (see the open issue) for long-form load tests to help find memory leaks, fuzz error conditions, and kick out races with enough time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to aid validation of bug fix for memcached proxy.
Still work in progress, not ready to merge.