Skip to content

update static analysis related things #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmoll wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update static analysis related things #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5b96c8
annotation for new pslam versions
mmoll Dec 13, 2025
705587d
install phan only for CI runs
mmoll Dec 13, 2025
073be8f
remove now unneeded pinning
mmoll Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,19 @@ jobs:
- name: Run psalm
if: ${{ matrix.os != 'windows-latest' }}
run: vendor/bin/psalm
- name: Run phan
- name: Install and run phan
if: ${{ matrix.os != 'windows-latest' }}
run: vendor/bin/phan
run: |
rm composer.lock
composer require ${{ matrix.dependencies_level }} --dev phan/phan:^5.4.5
vendor/bin/phan
# AST 1.1 binary for Windows seems to be missing on PECL
- name: Run phan with polyfill
- name: Install and run phan with polyfill
if: ${{ matrix.os == 'windows-latest' }}
run: vendor/bin/phan --allow-polyfill-parser
run: |
rm composer.lock
composer require ${{ matrix.dependencies_level }} --dev phan/phan:^5.4.5
vendor/bin/phan --allow-polyfill-parser
- name: Run tests with coverage
if: ${{ matrix.os != 'windows-latest' && matrix.php_version == '8.1' && matrix.dependencies_level != '--prefer-lowest' }}
run: php vendor/bin/phpunit --coverage-clover=coverage.xml --coverage-cobertura=cobertura.xml --log-junit=junit.xml
Expand Down
5 changes: 2 additions & 3 deletions .phan/config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
'directory_list' => [
'MO4',
'tests',
'vendor/squizlabs/php_codesniffer',
'vendor/symfony/polyfill-php83',
'vendor',
],

// A directory list that defines files that will be excluded
Expand All @@ -38,6 +37,6 @@
// should be added to both the `directory_list`
// and `exclude_analysis_directory_list` arrays.
"exclude_analysis_directory_list" => [
'vendor/'
'vendor/',
],
];
3 changes: 3 additions & 0 deletions MO4/Library/PregLibrary.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@

use PHP_CodeSniffer\Exceptions\RuntimeException;

/**
* @psalm-api
*/
final class PregLibrary
{
/**
Expand Down
2 changes: 0 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,10 @@
"require-dev": {
"ergebnis/composer-normalize": "^2.45",
"nikic/php-parser": "< 5.0.1",
"phan/phan": "^5.4.5",
"phpstan/phpstan": "^2.0",
"phpstan/phpstan-strict-rules": "^2.0",
"phpunit/phpunit": "^9.6.15",
"psalm/plugin-phpunit": "^0.19",
"sabre/event": ">= 5.1.6",
"symfony/filesystem": ">= 5.4.45",
"symfony/polyfill-php83": "^1.32",
"vimeo/psalm": "^6.0.0"
Expand Down
Loading