Fix IpRiskResponse decoding when ip_risk field is missing #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ipRisk field now uses useDefault=true, so it defaults to 0.0 when not present in the database record. A value of 0.0 indicates the risk score was not set. Added tests for IP Risk database reading. Also updates maxmind-db submodule to include test data for records without ip_risk field. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where IpRiskResponse decoding fails when the ip_risk field is missing from database records by defaulting to 0.0 instead of throwing an error.
- Added
useDefault=trueto the@MaxMindDbParameterannotation for theipRiskfield - Added comprehensive test coverage for IP Risk database reading, including a test case for records without the
ip_riskfield - Updated documentation to clarify that 0.0 indicates an unset risk score and added a TODO for future API improvement
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/resources/maxmind-db | Updated submodule to include test data for records without ip_risk field |
| src/test/java/com/maxmind/geoip2/DatabaseReaderTest.java | Added tests for IP Risk database reading, including handling of missing ip_risk field |
| src/main/java/com/maxmind/geoip2/model/IpRiskResponse.java | Added useDefault=true to ipRisk parameter and updated documentation |
| CHANGELOG.md | Documented the bug fix for version 5.0.2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
horgh
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ipRisk field now uses useDefault=true, so it defaults to 0.0 when
not present in the database record. A value of 0.0 indicates the risk
score was not set. Added tests for IP Risk database reading.
Also updates maxmind-db submodule to include test data for records
without ip_risk field.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com