allow BeautifulSoup configuration kwargs to be specified#224
Merged
chrispy-snps merged 1 commit intomatthewwithanm:developfrom Jun 14, 2025
Merged
Conversation
2d0a14a to
07d0500
Compare
AlexVonB
approved these changes
Jun 14, 2025
Collaborator
AlexVonB
left a comment
There was a problem hiding this comment.
Good solution! Since the option name changes, you should at least make this a minor release.
How do you handle the command line options? Could we just... ignore this option for the CLI? :D
Collaborator
Author
|
@AlexVonB - ack! Yes, I need to update the command-line script. I say we just accept only a string value for |
Signed-off-by: chrispy <chrispy@synopsys.com>
07d0500 to
e9d3de8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #223 by extending #206 to also support the specification of full
BeautifulSoupkwargs values.If a simple string or list is passed, the original behavior from #206 is used to treat it as a
featuresspecification:But if a dictionary is passed, then it is treated as a full kwargs specification: