Skip to content

MSC4140: drop delayed state interference tests #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndrewFerr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MSC4140: drop delayed state interference tests #845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 0 additions & 79 deletions tests/msc4140/delayed_event_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,85 +360,6 @@ func TestDelayedEvents(t *testing.T) {
})
})

t.Run("delayed state is not cancelled by new state from the same user", func(t *testing.T) {
var res *http.Response

stateKey := "to_not_be_cancelled_by_same_user"

defer cleanupDelayedEvents(t, user)

setterKey := "setter"
setterExpected := "on_timeout"
user.MustDo(
t,
"PUT",
getPathForState(roomID, eventType, stateKey),
client.WithJSONBody(t, map[string]interface{}{
setterKey: setterExpected,
}),
getDelayQueryParam("900"),
)
matchDelayedEvents(t, user, delayedEventsNumberEqual(1))

user.MustDo(
t,
"PUT",
getPathForState(roomID, eventType, stateKey),
client.WithJSONBody(t, map[string]interface{}{
setterKey: "manual",
}),
)
matchDelayedEvents(t, user, delayedEventsNumberEqual(1))

time.Sleep(1 * time.Second)
res = user.MustDo(t, "GET", getPathForState(roomID, eventType, stateKey))
must.MatchResponse(t, res, match.HTTPResponse{
JSON: []match.JSON{
match.JSONKeyEqual(setterKey, setterExpected),
},
})
})

t.Run("delayed state is cancelled by new state from another user", func(t *testing.T) {
var res *http.Response

stateKey := "to_be_cancelled_by_other_user"

defer cleanupDelayedEvents(t, user)
defer cleanupDelayedEvents(t, user2)

setterKey := "setter"
user.MustDo(
t,
"PUT",
getPathForState(roomID, eventType, stateKey),
client.WithJSONBody(t, map[string]interface{}{
setterKey: "on_timeout",
}),
getDelayQueryParam("900"),
)
matchDelayedEvents(t, user, delayedEventsNumberEqual(1))

setterExpected := "manual"
user2.MustDo(
t,
"PUT",
getPathForState(roomID, eventType, stateKey),
client.WithJSONBody(t, map[string]interface{}{
setterKey: setterExpected,
}),
)
matchDelayedEvents(t, user, delayedEventsNumberEqual(0))

time.Sleep(1 * time.Second)
res = user.MustDo(t, "GET", getPathForState(roomID, eventType, stateKey))
must.MatchResponse(t, res, match.HTTPResponse{
JSON: []match.JSON{
match.JSONKeyEqual(setterKey, setterExpected),
},
})
})

t.Run("delayed state events are kept on server restart", func(t *testing.T) {
// Spec cannot enforce server restart behaviour
runtime.SkipIf(t, runtime.Dendrite, runtime.Conduit, runtime.Conduwuit)
Expand Down
Loading