Fix homerunner CORS #835
Merged
Fix homerunner CORS #835
+16
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
commented
Dec 20, 2025
| ))), | ||
| ) | ||
| mux.Path("/destroy").Methods("POST").HandlerFunc( | ||
| util.WithCORSOptions(util.MakeJSONAPI(util.NewJSONRequestHandler( |
Collaborator
Author
There was a problem hiding this comment.
Previously, this was using matrix-org/util -> WithCORSOptions which only added the CORS headers to OPTIONS requests.
But we a) never accepted the OPTIONS method here and b) the CORS headers should also be on the non-OPTIONS requests.
devonh
approved these changes
Dec 22, 2025
Contributor
devonh
left a comment
devonh
left a comment
There was a problem hiding this comment.
Nice little cleanup. Thanks for this.
Collaborator
Author
|
Thanks for the review @devonh 🐫 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix homerunner CORS. Noticed while trying to use the homerunner API from a browser based tool.
Testing strategy
go run ./cmd/homerunnerhttp://localhost:54321/healthfrom another page in the browser (I'm using a local version of Hoppscotch)Pull Request Checklist