Review and modernization of the package#280
Review and modernization of the package#280kshitij-maths wants to merge 0 commit intomathLab:masterfrom
Conversation
|
Thanks @kshitij-maths can you check why all the tests are failing? We should fix them to merge the changes! |
|
@ndem0 checking. |
|
Please approve the current workflow. Let's see if it works. |
|
@ndem0 The macOS PR test is consistently failing because |
|
Ok thanks! Yes the action is not working for MacOS, they also have a warning on the main page https://github.com/s-weigand/setup-conda I would change the action so! I tried to quick search on google and there is the official action developed by Also please try to fix the Codacy issues, there are 64 new issues https://app.codacy.com/gh/mathLab/PyGeM/pull-requests/280/issues |
Okay, thanks!
Okay. |
ndem0
left a comment
There was a problem hiding this comment.
A huge amount of file are changed because of small formatting (double quotes instead signle one for example). Also, a lot of new file have been added, but I don't think are necessary (they should be the output of some tests).
Additionally, please try to keep few lines of changes for PR, around 100 is completely fine (here we have 6000 lines for 35 commits, definetely to large).
Please remove unnecessary file.
Please restore to the previous version all the file contined in pygem, tests and tutorials folders.
README.md
Outdated
There was a problem hiding this comment.
I don't think we need to revert the complete README to its original version. We've simply reorganized it for better clarity. If you look at the rendered file rather than the raw code, you'll see that the content is essentially the same, perhaps more polished and structured. The overwhelming number of added and deleted lines you see here is likely because I rewrote the file completely, rather than making changes line by line.
pyproject.toml
Outdated
a6e6f44 to
3c11eb1
Compare
This PR introduces several modernization improvements to the package, including: