Skip to content

Adapt to https://github.com/math-comp/math-comp/pull/1545#1860

Draft
proux01 wants to merge 1 commit intomath-comp:masterfrom
proux01:mc1545
Draft

Adapt to https://github.com/math-comp/math-comp/pull/1545#1860
proux01 wants to merge 1 commit intomath-comp:masterfrom
proux01:mc1545

Conversation

@proux01
Copy link
Collaborator

@proux01 proux01 commented Feb 26, 2026

Adapt to math-comp/math-comp#1545

This was automatically generated with

for f in $(find . -name "*.v") ; do awk -i inplace -f add_set_reworder.awk $f ; done

where add_set_reworder.awk is the following awk script

BEGIN {
  seen_mc_require= 0
  done= 0
}

/From mathcomp Require/ {
  seen_mc_require= 1
}

/^\r?$/ {
  if (seen_mc_require == 1 && done == 0) {
    print("Set SsrOldRewriteGoalsOrder.  (* change Set to Unset when porting the file, then remove the line when requiring MathComp >= 2.6 *)")
  }
  done= 1
}

{
  print($0)
}

@affeldt-aist
Copy link
Member

affeldt-aist commented Feb 27, 2026

I would like to start communicating about this change on the occasion of the next release
with a heads-up on Zulip.
What do you think about the following message?

fyi: @strub

Notice to MathComp-Analysis contributors:

This is just a heads-up about a significant change that should happen in
the near future.

We plan to change the default order of subgoals generated by the `rewrite`
tactic as the one implemented by the command `Unset SsrOldRewriteGoalsOrder`.
Indeed, very often when rewriting with a lemma one wants to discharge premises
as soon as possible, resulting in the frequent usage of, e.g., the `; last first`
tactical. `Unset SsrOldRewriteGoalsOrder` fixes this issue by generating premises
as the first subgoals. It is actually already in use in a few places in the source code.

The change should not affect end-users by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants