Skip to content

Comments

fix #1843#1855

Merged
affeldt-aist merged 1 commit intomath-comp:masterfrom
affeldt-aist:fix_1843
Feb 25, 2026
Merged

fix #1843#1855
affeldt-aist merged 1 commit intomath-comp:masterfrom
affeldt-aist:fix_1843

Conversation

@affeldt-aist
Copy link
Member

Motivation for this change

fix #1843

@holgerthies -> we discussed renaming on the closed_comp lemma recently, eventually I didn't use the name we though of at the time, what do you think? (in MathComp, when the predicate is unary, the order is reversed on purpose @CohenCyril )

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist added this to the 1.16.0 milestone Feb 24, 2026
@affeldt-aist affeldt-aist requested a review from zstone1 February 24, 2026 02:33
@affeldt-aist affeldt-aist added the renaming/refactoring 🔧 This is about a renaming or refactoring in the library label Feb 24, 2026
@holgerthies
Copy link

I think the lemma names are more accurate now.

@affeldt-aist affeldt-aist merged commit 2e35abf into math-comp:master Feb 25, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

renaming/refactoring 🔧 This is about a renaming or refactoring in the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

naming of closed_comp

2 participants