fix: create directory with fn.mkdir
#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Seems to have a some merge conflict. Please resolve them and let me know when you are done with it. |
Owner
|
Many vimscript functions cannot run inside lua loops. Are you sure vim.fn.mkdir doesnt suffer from this? |
Contributor
Author
|
Sorry it's not marked as I find someone have been make a compat here. So I remove it, although it would be better to have a |
Owner
|
The PR looks good. Is there anything else you are working on in this PR or should i merge it? @phanen |
Contributor
Author
|
Nothing more, thanks for review (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.