Fix use-external-python in the action#22
Conversation
|
Can you please move the v4 tag to the latest commit on this branch? Then I'll merge. |
What v4 tag? If you mean GitHub first-party Actions, I do have a separate local branch updating all of those. |
marian-code/python-lint-annotate@fd01666 broke setting the Python version for the action. While use-external-python works in .github/workflows/test-python-install.yml, it does not work in the action itself. This is because custom action inputs cannot use true booleans, so the use-external-python input is a string type. This string then always gets interpreted as "true", so the "Setup python" condition always resolves to "false" due to negation. Use fromJSON to correctly convert the strings "true" and "false" to boolean types.
RytoEX
force-pushed
the
fix-use-external-python
branch
from
0603f7b to
38fedd7
Compare
|
Rebased now that #21 is merged. I did not get these failures before, so I will go check into this quickly. I suspect that some older versions of Python must be dropped (3.8, 3.9), and I have those changes on a separate branch, so I will test my changes collectively on my repo. |
|
It turns out that the macOS 14 runners (and perhaps the macOS 15 runners) will fail to install Python 3.8-3.10: https://github.com/RytoEX/python-lint-annotate/actions/runs/22419941092 Python 3.11-3.14 seem to work fine. I see what happened, and it was my oversight in #21. Back when #16 landed, macos-latest was equivalent to macos-14: https://github.com/actions/runner-images/tree/6eccdcc56f1b3601f6a54393659b290ece561d24 When I changed |
|
I will push a separate PR to fix the oversight from #21, but I will also push a PR containing all of the fixes/updates in sequence so that it shows that all fixes work together. If it is easier to merge one PR instead of several, I will focus on that. |
2 participants
fd01666 (PR #16) broke setting the Python version for the action.
While use-external-python works in .github/workflows/test-python-install.yml, it does not work in the action itself. This is because custom action inputs cannot use true booleans, so the use-external-python input is a string type. This string then always gets interpreted as "true", so the "Setup python" condition always resolves to "false" due to negation.
Use fromJSON to correctly convert the strings "true" and "false" to boolean types.
To compare, see these before and after logs, paying special attention to the Python version in each job:
Please note that the action test will "fail" until #21 is merged because the macos-13 runners cannot initialize.