fix: ecDeriveBits returns full backing ArrayBuffer instead of truncat…#947
Merged
boorad merged 2 commits intomargelo:mainfrom Feb 17, 2026
Merged
Conversation
…ed slice TypedArray.subarray() creates a view, so .buffer returns the original full-size ArrayBuffer (e.g. 48 bytes for P-384). When deriveKey requests 256-bit AES-GCM, importKey receives 384 bits and throws 'Invalid AES key length'. Use ArrayBuffer.prototype.slice() to create a new ArrayBuffer with only the requested bytes. Add P-384 and P-521 regression tests for ECDH deriveKey to AES-GCM-256. Closes margelo#946
- Consolidate P-256/P-384/P-521 deriveKey tests into parameterized loop - Add AES-GCM-128 deriveKey tests for P-384 and P-521 - Add AES-CBC-256 deriveKey test for P-384 - Add deriveBits truncation tests verifying correct prefix extraction when requesting fewer bits than the curve's shared secret size - All tests exercise the margelo#946 regression: larger secrets must be properly truncated when deriving shorter keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypedArray.subarray() creates a view, so .buffer returns the original full-size ArrayBuffer (e.g. 48 bytes for P-384). When deriveKey requests 256-bit AES-GCM, importKey receives 384 bits and throws 'Invalid AES key length'.
Use ArrayBuffer.prototype.slice() to create a new ArrayBuffer with only the requested bytes.
Add P-384 and P-521 regression tests for ECDH deriveKey to AES-GCM-256.
Closes #946