Skip to content

Fix search form accessibility, design tokens, and AntD consistency #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcodejongh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix search form accessibility, design tokens, and AntD consistency #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/web/app/components/search-drawer/accordion-search-form.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
.sectionCard {
background: var(--ant-color-bg-container, #FFFFFF);
border-radius: 16px;
box-shadow: 0 1px 2px rgba(0, 0, 0, 0.06), 0 1px 3px rgba(0, 0, 0, 0.08);
box-shadow: var(--ant-box-shadow-tertiary, 0 1px 2px 0 rgba(0, 0, 0, 0.03), 0 1px 6px -1px rgba(0, 0, 0, 0.02), 0 2px 4px 0 rgba(0, 0, 0, 0.02));
overflow: hidden;
transition: box-shadow 200ms ease;
}
Expand All @@ -20,11 +20,11 @@
}

.sectionCard:not(.sectionCardActive):hover {
box-shadow: 0 2px 6px rgba(0, 0, 0, 0.1), 0 1px 3px rgba(0, 0, 0, 0.08);
box-shadow: var(--ant-box-shadow-secondary, 0 6px 16px 0 rgba(0, 0, 0, 0.08), 0 3px 6px -4px rgba(0, 0, 0, 0.12), 0 9px 28px 8px rgba(0, 0, 0, 0.05));
}

.sectionCardActive {
box-shadow: 0 3px 10px rgba(0, 0, 0, 0.1), 0 1px 4px rgba(0, 0, 0, 0.06);
box-shadow: var(--ant-box-shadow, 0 6px 16px 0 rgba(0, 0, 0, 0.08), 0 3px 6px -4px rgba(0, 0, 0, 0.12), 0 9px 28px 8px rgba(0, 0, 0, 0.05));
}

/* Collapsed row */
Expand Down
12 changes: 11 additions & 1 deletion packages/web/app/components/search-drawer/accordion-search-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,17 @@ const AccordionSearchForm: React.FC<AccordionSearchFormProps> = ({
<div
key={section.key}
className={`${styles.sectionCard} ${isActive ? styles.sectionCardActive : ''}`}
{...(!isActive ? { onClick: () => setActiveKey(section.key) } : {})}
{...(!isActive ? {
onClick: () => setActiveKey(section.key),
onKeyDown: (e: React.KeyboardEvent) => {
if (e.key === 'Enter' || e.key === ' ') {
e.preventDefault();
setActiveKey(section.key);
}
},
role: 'button',
tabIndex: 0,
} : {})}
>
{isActive ? (
<div className={styles.expandedContent}>
Expand Down
17 changes: 7 additions & 10 deletions packages/web/app/components/search-drawer/search-dropdown.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,16 @@

/* Clear all - underlined text link */
.clearAllButton {
background: none;
border: none;
padding: 0;
font-size: 16px;
font-weight: 600;
color: var(--ant-color-text, #111827);
text-decoration: underline;
cursor: pointer;
line-height: 1.5;
padding: 0 !important;
font-size: 16px !important;
font-weight: 600 !important;
color: var(--ant-color-text, #111827) !important;
text-decoration: underline !important;
height: auto !important;
}

.clearAllButton:hover {
color: var(--ant-color-text-secondary, #6B7280);
color: var(--ant-color-text-secondary, #6B7280) !important;
}

.clearAllButton:active {
Expand Down
6 changes: 3 additions & 3 deletions packages/web/app/components/search-drawer/search-dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ const SearchDropdown: React.FC<SearchDropdownProps> = ({ boardDetails, open, onC

const drawerFooter = (
<div className={styles.footer}>
<button
type="button"
<Button
type="link"
className={styles.clearAllButton}
onClick={clearClimbSearchParams}
>
Clear all
</button>
</Button>
<Button
type="primary"
icon={isFetchingClimbs ? <Spin size="small" /> : <SearchOutlined />}
Expand Down
Loading