[Android Auto] Remove mapbox navigation from PlaceListOnMapScreen#6371
Merged
[Android Auto] Remove mapbox navigation from PlaceListOnMapScreen#6371
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6371 +/- ##
============================================
+ Coverage 68.93% 68.94% +0.01%
+ Complexity 4589 4578 -11
============================================
Files 695 691 -4
Lines 27449 27376 -73
Branches 3195 3191 -4
============================================
- Hits 18921 18875 -46
+ Misses 7287 7262 -25
+ Partials 1241 1239 -2
|
9aef581 to
8c218a7
Compare
kmadsen
commented
Sep 26, 2022
| PlacesListItemMapper( | ||
| PlaceMarkerRenderer(mainCarContext.carContext), | ||
| mainCarContext | ||
| .mapboxNavigation |
Contributor
Author
There was a problem hiding this comment.
It's this dependency that needs to be moved, getting the unit type to become observable is a bit complicated
kmadsen
commented
Sep 26, 2022
libnavui-androidauto/api/current.txt
Outdated
|
|
||
| public final class CarLocationRenderer implements com.mapbox.maps.extension.androidauto.MapboxCarMapObserver { | ||
| ctor public CarLocationRenderer(com.mapbox.androidauto.car.MainCarContext mainCarContext); | ||
| method public void onAttached(com.mapbox.maps.extension.androidauto.MapboxCarMapSurface mapboxCarMapSurface); |
b8b545d to
594a48e
Compare
Zayankovsky
approved these changes
Sep 27, 2022
...droidauto/src/main/java/com/mapbox/androidauto/car/placeslistonmap/PlacesListOnMapManager.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's a lot of refactoring in order to get this to work. I also reached a point where it is better to dig into
CarRouteRequestbecause that class is a little painful to use withMapboxNavigationin the constructorScreenshots or Gifs