version flag for MapboxGeocoder #485
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladislavMedved
force-pushed
the
v6-api-support
branch
from
ee73618 to
63ec2e7
Compare
mpothier
requested changes
Jan 23, 2023
Contributor
mpothier
left a comment
mpothier
left a comment
There was a problem hiding this comment.
@VladislavMedved Great work, this is really close - just a few small changes
VladislavMedved
force-pushed
the
v6-api-support
branch
from
c5a0a4d to
57118b9
Compare
mpothier
reviewed
Jan 26, 2023
mpothier
requested changes
Jan 26, 2023
VladislavMedved
force-pushed
the
v6-api-support
branch
from
767f979 to
885c3ad
Compare
VladislavMedved
force-pushed
the
v6-api-support
branch
from
8460ea5 to
d490057
Compare
mapbox-danny
reviewed
Mar 7, 2023
mapbox-danny
reviewed
Mar 7, 2023
mapbox-danny
reviewed
Mar 7, 2023
Contributor
|
Be sure to remove the yarn lock |
VladislavMedved
force-pushed
the
v6-api-support
branch
from
d490057 to
2320845
Compare
VladislavMedved
force-pushed
the
v6-api-support
branch
from
ff9dc23 to
64f3267
Compare
pre-validate reverse coordinates to avoid v6 4xx response fix limit=1 on reverse geocodes when single type set enable multiple reverse results when no types or limit specified fix promise resolution revert package-lock file fix potential problem with address strings for v5 and v6
VladislavMedved
force-pushed
the
v6-api-support
branch
from
64f3267 to
9199750
Compare
Contributor
Author
|
VladislavMedved
changed the title
|
Is anyone still working on this? It would be really cool to see API v6 in the geocoder |
|
Pinging once again because it's getting ridiculous. |
Contributor
|
@MateuszKukiela I recommend checking out the Mapbox Search JS SDK, which is the newer SDK and uses the Geocoding V6 API in its libraries: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adds
version="v5"|"v6"flag to the options ofMapboxGeocoderclass that allows using v6 endpoint instead of default v5 when geocoding.Gl-geocoder in v6 mode can initiate
forwardandreversegeocoding calls