Fix the size of image enlarge twice in coordsFromBbox#28
Open
jingsam wants to merge 10 commits intomapbox:masterfrom
Open
Fix the size of image enlarge twice in coordsFromBbox#28jingsam wants to merge 10 commits intomapbox:masterfrom
jingsam wants to merge 10 commits intomapbox:masterfrom
Conversation
added 2 commits
July 19, 2016 20:04
|
Thanks for checking this out @jingsam. I'd like like to keep tileSize as an optional parameter. Can we check for |
Author
|
OK, already done |
Author
|
Fixed more bugs. @bsudekum |
added 2 commits
July 20, 2016 16:27
Author
|
Pokémon GO! I caught six bugs today in abaculus 🎱 |
Author
|
@bsudekum would you mind to merge these PRs and publish a new version to npm? |
|
Also cc @tmcw @camilleanne. There are a decent amount of changes here. |
| center.w = Math.round(center.w * s); | ||
| center.h = Math.round(center.h * s); | ||
|
|
||
| if (center.w >= limit || center.h >= limit) throw new Error('Desired image is too large.'); |
There was a problem hiding this comment.
Why is limit and this check being removed?
There was a problem hiding this comment.
Author
There was a problem hiding this comment.
Throw errors in functions is not a good practice, put it in callback may be better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.