Refactor - Consolidating duplicate code. Minor bug fixes#73
Refactor - Consolidating duplicate code. Minor bug fixes#733choBoomer wants to merge 8 commits intomagic-chunks:masterfrom
Conversation
| var document = new YamlDocument(@"a: | ||
| x: 1 | ||
| b: 2 | ||
| c: 3"); |
There was a problem hiding this comment.
I moved the check for the lack of a root object from the call to ReplaceKey to the constructor since it could be checked with no other data required.
Because of this, the constructor now throws the Root Element Not Present error.
This test was modified to only validate the empty path exception, and a new test was added below to verify that the no root element exception is thrown by the constructor.
|
Looks like npm is throwing a few minor security warnings and that is breaking the build:
|
I started using magic-chunks recently and after looking through the code, I wanted to contribute a little.
I saw a decent amount of duplicated code blocks and some minor issues with grammar and parameter order that I wanted to resolve.
All tests pass with only two minor changes to the tests themselves. One of them was to eliminate the hiding of an error due to the order that the parameters were being checked. (see inline note).
Please review and provide feedback.
Thanks for making this tool, it's quite helpful!