fix: remove userIdentities key expectation in native iOS logic #255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Setting identities through the mParticle module running on iOS resulted in those identities not being passed through to the mParticle dashboard. This is down to a mismatch between the codegen spec and the iOS implementation:
react-native-mparticle/js/codegenSpecs/NativeMParticle.ts
Line 106 in 9801934
react-native-mparticle/ios/RNMParticle/RNMParticle.mm
Lines 648 to 672 in 9801934
and
react-native-mparticle/ios/RNMParticle/RNMParticle.mm
Lines 1090 to 1112 in 9801934
This PR removes the expectation that there will be a
userIdentitiesdict in the identity request in the native iOS code and aligns its implementation with the interface described by the codegen spec