feat: Update dependencies and implement Rokt #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sideloaded kit integration * Testing sideloading integration * Fix dependency version * Changes due to comments * Adding kitId in constructor due to change in architecture * Implementing default functions from KitIntegration * Adding minimal sideloading kit example and kit-base dependency
This was referenced Jul 11, 2025
thomson-t
approved these changes
Jul 16, 2025
|
|
||
|
|
||
| const val DEFAULT_PRODUCT_IMAGE = R.drawable.product_image_placeholder | ||
| var DEFAULT_PRODUCT_IMAGE = R.drawable.product_image_placeholder |
Contributor
There was a problem hiding this comment.
Can't see it is used anywhere in this PR. Do we need this?
Contributor
Author
There was a problem hiding this comment.
It's referenced by several classes within the application e.g. CartItemCard.kt
thomson-t
added a commit
that referenced
this pull request
Nov 24, 2025
* feat: Adding simple sample instrumentation test for ShopViewModel (#151) * feat: Update dependencies and implement Rokt (#279) * feat: sideloaded kit integration (#211) * Sideloaded kit integration * Testing sideloading integration * Fix dependency version * Changes due to comments * Adding kitId in constructor due to change in architecture * Implementing default functions from KitIntegration * Adding minimal sideloading kit example and kit-base dependency * Base updates for AGP * Remove excessive logging * Update deps to use BOM and add Rokt * Add Rokt overlay placement post checkout * Add Rokt close implementation * Add event logging and auto close * Migrate to toml version management * Add lint baseline * Add standard files * Migrate missed plugins * Add versions to toml file * Add permissions * Bump upload artifact version * Add concurrency * Remove main qualifier * Use local reference * Bump versions * Change runner to recommended by reactivecircus * Bump gradle version * Update settings.gradle.kts --------- Co-authored-by: markvdouw <v-mvanderouw@mparticle.com> * fix: desugar build error --------- Co-authored-by: markvdouw <mark.vdouw@gmail.com> Co-authored-by: James Newman <james.newman@rokt.com> Co-authored-by: markvdouw <v-mvanderouw@mparticle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
Summary
Testing Plan
RoktClose.webm
Reference Issue