Skip to content

Conversation

@luau-project
Copy link
Collaborator

@luau-project luau-project commented Jun 6, 2025

Changes

  1. small introduction of lua -v to see the version when testing the interpreter on CI.

  2. not sure whether it is desired or not, but I modified docs assuming an upcoming v11 release. In case a v11 release is not on plan soon, I can revert these changes on docs. What do you think?

@luau-project luau-project marked this pull request as draft June 7, 2025 14:38
@luau-project luau-project marked this pull request as ready for review June 23, 2025 13:32
@luau-project
Copy link
Collaborator Author

Update

  1. minimal changes were applied mostly to update from previous 5.4.X to the current 5.4.8 version
  2. added an action to load MSVC dev prompt to allow CI to pass (it was failing without it)

CC @hishamhm

@hishamhm hishamhm merged commit 5c54131 into luarocks:master Jun 23, 2025
64 checks passed
@hishamhm
Copy link
Member

@luau-project Sorry I missed this earlier — if you want to push a v11 tag or make further updates (the readme seems out of date too?), feel free to do it! I assume you should be able to, with maintainer status on this repo!

@luau-project
Copy link
Collaborator Author

Fine. I'll give it a week for people depending on master branch to test the changes. In case no one complains in a week, I'll update README, and push a new tag in order to CI release a v11 then. Note: If I understood correctly, CI automatically publishes a new release based on publish.yml workflow.

I'll ping you once it is time.

@luau-project luau-project deleted the lua-5.4.8 branch June 23, 2025 17:10
@hishamhm
Copy link
Member

If I understood correctly, CI automatically publishes a new release based on publish.yml workflow.

I think so too!

@luau-project
Copy link
Collaborator Author

@hishamhm

One week has gone. I think it is time to make minor updates on both actions gh-actions-lua and gh-actions-luarocks.

Also, I've been thinking to transition them to a rolling release scheme, refactoring examples on README to depend on master branch (e.g.: - uses: luarocks/gh-actions-lua@master), rather than a pinned tag or release version. Looking at many repos (lunarmodules, teal, etc), I think this is the way most people use them.

What are your thoughts on this?

@hishamhm
Copy link
Member

What are your thoughts on this?

I think beyond our small Lua sphere, what I'm seeing being most recommended nowadays is to not promote @master, but instead tagged versions or even specific hashes, for greater reproducibility and being less succeptible to supply-chain attacks.

@luau-project
Copy link
Collaborator Author

Agreed.

If you didn't trigger it yet, I think it is time for you to "battle test" the new feature on LuaRocks repo (luarocks/luarocks#1808) by triggering manually the PR creation on gh-actions-luarocks through the selection of v3.12.2 tag on GitHub web UI.

@hishamhm
Copy link
Member

hishamhm commented Jun 30, 2025

Ah, looks like I can't trigger it on the tag because it predates the addition of the feature. I guess we'll test it in v3.12.3 whenever that comes!

@luau-project
Copy link
Collaborator Author

@hishamhm

Just to let you know:

  1. I performed minor changes on both repos (gh-actions-lua and gh-actions-luarocks) based on the details discussed here;
  2. Then pushed new tags on both.

PS: On both repos, docs already reflect the new versions and tags on examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants