Skip to content

fix determining the response body tag name#494

Open
underoll wants to merge 1 commit intoloopbackio:masterfrom
underoll:master
Open

fix determining the response body tag name#494
underoll wants to merge 1 commit intoloopbackio:masterfrom
underoll:master

Conversation

@underoll
Copy link

@underoll underoll commented Dec 4, 2022

Description

Looks like outputBodyDescriptor.elements[0].qname.name will never work, because it takes one level deeper then needed.
If it has the reason, i'd propose to return obj.Body as the result in case it is still empty after the three guesses.

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

Signed-off-by: Andrey Doronin <adoronin@naumen.ru>
@underoll
Copy link
Author

underoll commented Dec 5, 2022

Same is here https://github.com/vpulim/node-soap/blob/master/src/client.ts#L341
Cant imagine the reason for .elements[0]...

@dhmlau
Copy link
Member

dhmlau commented Aug 18, 2025

@underoll, sorry about the delay in reviewing your PR. There are test failures caused by your change. Could you please take a look if you're still interested in pursuing? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants