This repository was archived by the owner on Aug 7, 2025. It is now read-only.
Use get_latest_*_metrics.sh scripts from meta repository#1718
Merged
Conversation
|
🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1718.surge.sh 🎊 |
Member
Author
|
New run: https://github.com/localstack/docs/actions/runs/14193057557/job/39761931231 (cancelled it so it does not create a PR, but the download succeeded as expected) |
alexrashed
approved these changes
Apr 1, 2025
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Nice cleanup! Thanks for the push to make the scripts reusable and deliberately switching to its usage everywhere! 💯 🧹
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We need the
get_latest_*_metrics.shscripts from different repositories now, so they have been added to the localstack/meta repository.To avoid having them in multiple locations, we should get them from the meta repository in the docs workflows as well.
Changes
get_latest_*_metrics.shscripts from the meta repository