Skip to content

fix: harden Room event handling against crashes and native leaks #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
darshankparmar wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: harden Room event handling against crashes and native leaks #179

darshankparmar wants to merge 2 commits into from

Conversation

@darshankparmar
Copy link

@darshankparmar darshankparmar commented Jan 5, 2026

Fixes two Room.cs safety issues:

  1. Prevents crashes when TrackSubscribed arrives before publication state is initialized.
  2. Disposes unhandled text/byte stream readers to avoid native resource leaks.

No API changes; behavior is unchanged for valid flows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@darshankparmar