fix: race condition in connection pool initialization #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements double-checked locking in AsyncDatabaseConfig and SyncDatabaseConfig to prevent multiple pools from being created when provide_pool is called concurrently. Fixes #346
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #346.
Implements double-checked locking in
AsyncDatabaseConfigandSyncDatabaseConfigto ensure thread-safe and coroutine-safe pool initialization.This prevents the issue where concurrent calls to
provide_pool()(or implicit pool creation via session/connection provision) could create multiple pool instances, leading to 'invalid connection' errors when releasing connections.Added
tests/integration/test_pool_concurrency.pywhich reliably reproduces the race condition (failing before this fix) and verifies the fix.