Rails8 #399
Draft
Rails8 #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dépendant de la gemme rails-sass-images qui n'est plus développée
l'évolution de la gemme
Ajout de "optional: true" pour les modèles qui permettent une valeur "null". Document du comportement belongs_to: https://sipsandbits.com/2015/09/21/whats-new-in-rails-5/#belongs_toisrequiredbydefault
Il y avait deux classes pour dynamiquement chercher des templates entre les espaces de rédaction et modération, après tests et recherches il semble que ça ne soit pas (ou plus?) nécessaire.
les espaces de rédaction et modération
Tests et validations nécessaires, mais en pause car migration vers 7 prévue
…s non fonctionnelles
La méthode est maintenant nommée File.exist?
qui sont à peu près touts couverts
(en tous cas du code testé d'après la gemme simplecov...)
(semble non utilisé dans l'IHM)
Il pourrait y avoir d'autres cas, cela vient de la simplification de recherche des chemins de partiaux, suite (ou grâce) à la migration à rails 7
Il manque les contrôleurs d'API dans cette couverture...
- bookmarks: unique title, unique URL, force lang definition - news (direct to moderation): force section definition, force lang definition on links, different messages for max length of news title and link title - news (in redaction): force lang definition on links, different messages for max length of news title and link title - trackers: for category definition
As title and link are both mandatory, we set the lang mandatory too. The "xx" language code is removed from the valid list and blank is refused. The "xx" value was used as default value before we enable "blank" in form. It is not really useful now except for links and bookmarks which are already using this value.
This way, the errors is easier to see at they appear first on screen.
This shows a user friendly message instead of an exception if user remove the client side validation of section. The exception were thrown by the preview, so we avoid to show preview and submit button for invalid news.
The bookmark attribute for URL is "link" and not "url".
The inclusion validator already does the job correctly.
bookmarks: title uniqueness/strip/100->160 char, link uniqueness, missing tags field comments: title strip diaries: title 100->160 char, missing tags field forums: title strip lang: missing difference function links: title strip news: title strip/100->160 char, missing tags field nodes: missing tags field polls: title strip posts: title strip/100->160 char, missing tags field tracker: title strip wikipages: title strip, message trim, missing tags field
- Target Debian Trixie (stable) - Update MySQL/MariaDB package names - Simplify Bundler installation (now included with Ruby) - Improve document structure and add syntax highlighting
12 tasks
Add extra validations for links, trackers; and news
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.