fix(cli): resolve race condition in locale processing #1683
+83
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@vrcprl #1662 didn't fully fix #1661 because there's a race condition in
_utils.tswherepullInputandpullOutputare stored as single values that get overwritten on eachpull()callChanges
MapTesting
Business logic tests added:
I also made sure to test locally with
npm linkthis time. Sorry I didn't do it last time.Visuals
Required for UI/UX changes:
Checklist
Closes #1661