Skip to content

Open and accept zero reserve channels #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tankyleo wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Open and accept zero reserve channels #4428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
69ef6bf
Add inbound and outbound checks for zero reserve channels
tankyleo Feb 19, 2026
de75ac7
Use `accept_inbound_channel_from_trusted_peer` to accept 0 reserve chans
tankyleo Feb 26, 2026
a73d8ff
Add `create_channel_to_trusted_peer` to create outbound 0 reserves chans
tankyleo Feb 19, 2026
524fa7c
Define and signal the staging zero reserve feature
tankyleo Feb 12, 2026
5f75975
Shakedown zero reserve channels
tankyleo Feb 8, 2026
5fa3a7c
Format `ChannelManager::create_channel_internal` and...
tankyleo Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lightning-liquidity/tests/lsps2_integration_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1513,10 +1513,12 @@ fn create_channel_with_manual_broadcast(
Event::OpenChannelRequest { temporary_channel_id, .. } => {
client_node
.node
.accept_inbound_channel_from_trusted_peer_0conf(
.accept_inbound_channel_from_trusted_peer(
&temporary_channel_id,
&service_node_id,
user_channel_id,
true,
false,
None,
)
.unwrap();
Expand Down
19 changes: 17 additions & 2 deletions lightning-types/src/features.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,8 @@ mod sealed {
,
// Byte 19
HtlcHold,
// Byte 20
ZeroReserveStaging,
]
);
define_context!(
Expand Down Expand Up @@ -204,8 +206,10 @@ mod sealed {
,
// Byte 19
HtlcHold,
// Byte 20 - 31
,,,,,,,,,,,,
// Byte 20
ZeroReserveStaging,
// Byte 21 - 31
,,,,,,,,,,,
// Byte 32
DnsResolver,
]
Expand Down Expand Up @@ -721,6 +725,17 @@ mod sealed {
supports_htlc_hold,
requires_htlc_hold
);
define_feature!(
165,
ZeroReserveStaging,
[InitContext, NodeContext],
"Feature flags for zero reserve.",
set_zero_reserve_optional,
set_zero_reserve_required,
clear_zero_reserve,
supports_zero_reserve,
requires_zero_reserve
);
define_feature!(
259,
DnsResolver,
Expand Down
2 changes: 1 addition & 1 deletion lightning/src/events/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1643,7 +1643,7 @@ pub enum Event {
/// Furthermore, note that if [`ChannelTypeFeatures::supports_zero_conf`] returns true on this type,
/// the resulting [`ChannelManager`] will not be readable by versions of LDK prior to
/// 0.0.107. Channels setting this type also need to get manually accepted via
/// [`crate::ln::channelmanager::ChannelManager::accept_inbound_channel_from_trusted_peer_0conf`],
/// [`crate::ln::channelmanager::ChannelManager::accept_inbound_channel_from_trusted_peer`],
/// or will be rejected otherwise.
///
/// [`ChannelManager`]: crate::ln::channelmanager::ChannelManager
Expand Down
8 changes: 6 additions & 2 deletions lightning/src/ln/async_signer_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,12 @@ fn do_test_open_channel(zero_conf: bool) {
Event::OpenChannelRequest { temporary_channel_id, .. } => {
nodes[1]
.node
.accept_inbound_channel_from_trusted_peer_0conf(
.accept_inbound_channel_from_trusted_peer(
temporary_channel_id,
&node_a_id,
0,
true,
false,
None,
)
.expect("Unable to accept inbound zero-conf channel");
Expand Down Expand Up @@ -383,10 +385,12 @@ fn do_test_funding_signed_0conf(signer_ops: Vec<SignerOp>) {
Event::OpenChannelRequest { temporary_channel_id, .. } => {
nodes[1]
.node
.accept_inbound_channel_from_trusted_peer_0conf(
.accept_inbound_channel_from_trusted_peer(
temporary_channel_id,
&node_a_id,
0,
true,
false,
None,
)
.expect("Unable to accept inbound zero-conf channel");
Expand Down
8 changes: 6 additions & 2 deletions lightning/src/ln/chanmon_update_fail_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3235,7 +3235,9 @@ fn do_test_outbound_reload_without_init_mon(use_0conf: bool) {
if use_0conf {
nodes[1]
.node
.accept_inbound_channel_from_trusted_peer_0conf(&chan_id, &node_a_id, 0, None)
.accept_inbound_channel_from_trusted_peer(
&chan_id, &node_a_id, 0, true, false, None,
)
.unwrap();
} else {
nodes[1].node.accept_inbound_channel(&chan_id, &node_a_id, 0, None).unwrap();
Expand Down Expand Up @@ -3344,7 +3346,9 @@ fn do_test_inbound_reload_without_init_mon(use_0conf: bool, lock_commitment: boo
if use_0conf {
nodes[1]
.node
.accept_inbound_channel_from_trusted_peer_0conf(&chan_id, &node_a_id, 0, None)
.accept_inbound_channel_from_trusted_peer(
&chan_id, &node_a_id, 0, true, false, None,
)
.unwrap();
} else {
nodes[1].node.accept_inbound_channel(&chan_id, &node_a_id, 0, None).unwrap();
Expand Down
Loading
Loading